This repository was archived by the owner on Oct 19, 2022. It is now read-only.
Make enum types pass validation#46
Open
svenschwermer wants to merge 1 commit intojustanr:next-releasefrom
Open
Make enum types pass validation#46svenschwermer wants to merge 1 commit intojustanr:next-releasefrom
svenschwermer wants to merge 1 commit intojustanr:next-releasefrom
Conversation
marshmallow 3.0.0 doesn't perform validation during dump[s]. In order to
get the equivalent behaviour as before, validate must be called. However,
this fails with "Enum name must be string" for the following MWE:
class MyEnum(Enum):
a = 1
class MySchema(Schema):
my_field = EnumField(MyEnum)
errors = MySchema().validate({"my_field": MyEnum.a})
assert not errors
Internally, validate calls _do_load which invokes _deserialize aon all
fields. If there is nothing to deserialize, i.e. the type is already
correct, don't do anything.
Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
marshmallow 3.0.0 doesn't perform validation during dump[s]. In order to
get the equivalent behaviour as before, validate must be called. However,
this fails with "Enum name must be string" for the following MWE:
Internally, validate calls _do_load which invokes _deserialize aon all
fields. If there is nothing to deserialize, i.e. the type is already
correct, don't do anything.
Signed-off-by: Sven Schwermer sven.schwermer@disruptive-technologies.com