This repository was archived by the owner on Jan 10, 2020. It is now read-only.
Corrected deserializedItemStack implementation, custom logging ...#5
Open
Qveshn wants to merge 2 commits intojustblender:masterfrom
Open
Corrected deserializedItemStack implementation, custom logging ...#5Qveshn wants to merge 2 commits intojustblender:masterfrom
Qveshn wants to merge 2 commits intojustblender:masterfrom
Conversation
…little refactoring
1. Workaround with packets without player (player==null)
2. Workaround with deserializedItemStack from ProtocolLib (function was rewritten from ProtocolLib)
3. Exceptions wais divided in two groups:
ExploitException - when to kick player
Throwable - other exceptions which means internal plugin errors. Plugin only cancels event here. These errors should be corrected if they appear.
4. Custom logging of players that exploits packets has been added. Log file is in player folder, and holds not only players who exploit packet,
but also info about ItemStack with NbtCompound tags as json
5. Two options were added to config.yml: EnableCustomLog and CustomLogFormat
6. There was "magic" phrase added to the code ("CustomPayloadFixer" on first page). This allows admins to test how plugin works.
7. Plugin version was change to "1.5.1 X". DO NOT FORGET TO RENAME AFTER MERGE.
ToDo: There is no yet custom logging in bungee part, but it is easy to implement by analogy with bukkit part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExploitException - when to kick player
Throwable - other exceptions which means internal plugin errors. Plugin only cancels event here. These errors should be corrected if they appear.
but also info about ItemStack with NbtCompound tags as json
ToDo: There is no yet custom logging in bungee part, but it is easy to implement by analogy with bukkit part.