Skip to content
This repository was archived by the owner on Jan 10, 2020. It is now read-only.

Corrected deserializedItemStack implementation, custom logging ...#5

Open
Qveshn wants to merge 2 commits intojustblender:masterfrom
Qveshn:master
Open

Corrected deserializedItemStack implementation, custom logging ...#5
Qveshn wants to merge 2 commits intojustblender:masterfrom
Qveshn:master

Conversation

@Qveshn
Copy link

@Qveshn Qveshn commented Jan 15, 2018

  1. Workaround with packets without player (player==null)
  2. Workaround with deserializedItemStack from ProtocolLib (function was rewritten from ProtocolLib)
  3. Exceptions wais divided in two groups:
    ExploitException - when to kick player
    Throwable - other exceptions which means internal plugin errors. Plugin only cancels event here. These errors should be corrected if they appear.
  4. Custom logging of players that exploits packets has been added. Log file is in player folder, and holds not only players who exploit packet,
    but also info about ItemStack with NbtCompound tags as json
  5. Two options were added to config.yml: EnableCustomLog and CustomLogFormat
  6. There was "magic" phrase added to the code ("CustomPayloadFixer" on first page). This allows admins to test how plugin works.
  7. Plugin version was change to "1.5.1 X". DO NOT FORGET TO RENAME AFTER MERGE.

ToDo: There is no yet custom logging in bungee part, but it is easy to implement by analogy with bukkit part.

…little refactoring

1. Workaround with packets without player (player==null)
2. Workaround with deserializedItemStack from ProtocolLib (function was rewritten from ProtocolLib)
3. Exceptions wais divided in two groups:
     ExploitException - when to kick player
     Throwable - other exceptions which means internal plugin errors. Plugin only cancels event here. These errors should be corrected if they appear.
4. Custom logging of players that exploits packets has been added. Log file is in player folder, and holds not only players who exploit packet,
   but also info about ItemStack with NbtCompound tags as json
5. Two options were added to config.yml: EnableCustomLog and CustomLogFormat
6. There was "magic" phrase added to the code ("CustomPayloadFixer" on first page). This allows admins to test how plugin works.
7. Plugin version was change to "1.5.1 X". DO NOT FORGET TO RENAME AFTER MERGE.

ToDo: There is no yet custom logging in bungee part, but it is easy to implement by analogy with bukkit part.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant