fixed bug with mean calculation in fisher linear discriminant#11
Open
steevelaquitaine wants to merge 1 commit intomasterfrom
Open
fixed bug with mean calculation in fisher linear discriminant#11steevelaquitaine wants to merge 1 commit intomasterfrom
steevelaquitaine wants to merge 1 commit intomasterfrom
Conversation
When a class only has two instances and is used in leave-one-out. Only one instance (x1, 1 by N dimensional vector) is used for training fisher linear discriminant. Fisher linear discriminant needs the mean instance coordinates to calculate the classifier weights. The bug is that mean(x1), the average coordinates (a scalar) is wrong in that case, but mean(x1,1) the average instance coordinates is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class only has two instances and is used in leave-one-out. Only
one instance (x1, 1 by N dimensional vector) is used for training
fisher linear discriminant. Fisher linear discriminant needs the mean
instance coordinates to calculate the classifier weights. The bug is
that mean(x1), the average coordinates (a scalar) is wrong in that
case, but mean(x1,1) the average instance coordinates is correct.