Make HTTP timeout configurable via environment variable#4
Open
DaivikDave wants to merge 2 commits intomasterfrom
Open
Make HTTP timeout configurable via environment variable#4DaivikDave wants to merge 2 commits intomasterfrom
DaivikDave wants to merge 2 commits intomasterfrom
Conversation
- Add HTTP_TIMEOUT_SECONDS environment variable - Replace hardcoded 5s timeout with configurable value - Add validation for positive integer values - Default to 5 seconds if not set or invalid - Add HTTPTimeoutSeconds field to Server struct 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace deprecated infra_build_docker.yml with build-push-image.yml - Update workflow format to match working examples from jw-gateway 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
DaivikDave
force-pushed
the
configurable-http-timeout
branch
from
6661bd6 to
ca19c63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTP_TIMEOUT_SECONDSenvironment variableChanges
HTTP_TIMEOUT_SECONDSenvironment variable supportDEFAULT_HTTP_TIMEOUT_SECONDSconstant (5 seconds)HTTPTimeoutSecondsfield toServerstructgetHTTPTimeoutSeconds()helper function with validationServeHTTPto use configurable timeout valueBehavior
HTTP_TIMEOUT_SECONDSis not set: uses 5-second defaultHTTP_TIMEOUT_SECONDSis invalid (non-numeric or ≤0): logs warning and uses defaultHTTP_TIMEOUT_SECONDSis valid: uses configured valueExample Usage
🤖 Generated with Claude Code