Skip to content

Fix ifconfig parsing#2

Open
jsl123 wants to merge 2 commits intojwieder:masterfrom
jsl123:fix_ifconfig_parsing
Open

Fix ifconfig parsing#2
jsl123 wants to merge 2 commits intojwieder:masterfrom
jsl123:fix_ifconfig_parsing

Conversation

@jsl123
Copy link

@jsl123 jsl123 commented Oct 12, 2017

Fixed some small issues...
BTW: Thank you for the script and the necessary information! :-)

Things done

  • Minor markdown fix
  • Made MAC detection more robust. ifconfig is only used as fallback, since most of the time we use ip in this script anyway...
  • Changed installation folder from /usr/bin/ to /usr/sbin since this script may only be run by root as it does change IP addresses. Linux FHS says to install such scripts in a "root only" folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments