Fix #76 and bug when message containing backslash#103
Open
ssl19 wants to merge 2 commits intojwiegley:masterfrom
Open
Fix #76 and bug when message containing backslash#103ssl19 wants to merge 2 commits intojwiegley:masterfrom
ssl19 wants to merge 2 commits intojwiegley:masterfrom
Conversation
String encode is not need in alert-osx-notifier-notify method
When we use log4e to log alert events, alert messages containing backslashes will raise errors. (alert "\\") will raise: log4e--logging: Invalid use of ‘\’ in replacement text Check aki2o/log4e#9 for more information. This commit is a workaround for log4e upstream, and should be removed after aki2o/log4e#9 is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.