Skip to content

feat: Make notifications asynchronous#119

Open
LemonBreezes wants to merge 1 commit intojwiegley:masterfrom
LemonBreezes:make-notification-processes-asynchronous
Open

feat: Make notifications asynchronous#119
LemonBreezes wants to merge 1 commit intojwiegley:masterfrom
LemonBreezes:make-notification-processes-asynchronous

Conversation

@LemonBreezes
Copy link
Copy Markdown

Closes #116.

@jwiegley
Copy link
Copy Markdown
Owner

How best to test that this doesn't break current users?

@LemonBreezes
Copy link
Copy Markdown
Author

How best to test that this doesn't break current users?

Well, it works for me on Linux with the libnotify alert style. Since you use Mac OS, you can try it with the Growl notification style etc. But since the change is fairly uniform, it should work everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not call alert subprocesses synchronously

2 participants