test: add regression test for CPU autocast device-type behavior#671
Open
khanfs wants to merge 1 commit intojwohlwend:mainfrom
Open
test: add regression test for CPU autocast device-type behavior#671khanfs wants to merge 1 commit intojwohlwend:mainfrom
khanfs wants to merge 1 commit intojwohlwend:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #662
Adds a focused regression test covering CPU autocast device-type behavior.
Inside a CPU autocast context, disabling autocast with
device_type="cuda"does not actually disable CPU autocast, while disabling withdevice_type="cpu"does. This test captures that distinction explicitly.Why
This helps preserve the intended fix direction discussed in the CPU autocast issue and protects against future regressions in precision-sensitive code paths.
Changes
tests/test_autocast_precision.pytorch.autocast("cuda", enabled=False)does not disable CPU autocast inside a CPU autocast contexttorch.autocast("cpu", enabled=False)does disable CPU autocast in that contextNotes
This PR adds regression coverage only. It does not change runtime behavior.