-
Notifications
You must be signed in to change notification settings - Fork 0
Add concepts, collections and system settings to package #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add concepts, collections and system settings to package #23
Conversation
samuelscandrett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
| "c5a2b94a-fadd-11e6-a029-6c4008b05c4c": { | ||
| "en": { | ||
| "direction": "ltr", | ||
| "value": "Arches" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the only possible change here is whether their instance is called something other than "Arches" e.g. "Jersey Heritage".
|
The test seems to be failing on this line of fix_HER_length https://github.com/k-int/arches-Jersey/blob/5c29042e24324f9a3d61af8b63676848c3a7d661/jersey_her/management/commands/fix_HER_length.py#L23 |
|
@samuelscandrett - I refreshed that test again and it's now passing. I think the above was a warning and the error is here:
It looks as though it might be something to do with checking python coverage, and you can see that the python coverage check is now failing instead. Could we just remove this check in the context of this repo? |
|
Pkg was a level higher than it is for comparable projects, so I've moved it a layer down, into Testing on another instance, there also seems to be an issue importing some of the thesauri, so I'm looking at that now. |
|
I hadn't noticed you placed |
|
This is now loading in a local test instance without any issues. |
samuelscandrett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a Jersey environment to test, but if it's working for you I'm happy to merge.
Add concepts, collections and system settings to package, as well as the management command for exporting all thesauri.