Skip to content

Conversation

@CWDamm-Kint
Copy link
Collaborator

Add concepts, collections and system settings to package, as well as the management command for exporting all thesauri.

Copy link
Member

@samuelscandrett samuelscandrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

"c5a2b94a-fadd-11e6-a029-6c4008b05c4c": {
"en": {
"direction": "ltr",
"value": "Arches"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the only possible change here is whether their instance is called something other than "Arches" e.g. "Jersey Heritage".

@samuelscandrett
Copy link
Member

@CWDamm-Kint
Copy link
Collaborator Author

@samuelscandrett - I refreshed that test again and it's now passing. I think the above was a warning and the error is here:

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

It looks as though it might be something to do with checking python coverage, and you can see that the python coverage check is now failing instead. Could we just remove this check in the context of this repo?

@CWDamm-Kint
Copy link
Collaborator Author

Pkg was a level higher than it is for comparable projects, so I've moved it a layer down, into jersey_her

Testing on another instance, there also seems to be an issue importing some of the thesauri, so I'm looking at that now.

@samuelscandrett
Copy link
Member

I hadn't noticed you placed pkg/ on the same level as manage.py - it should be in the jersey_her/ dir as you've correctly identified.

@CWDamm-Kint
Copy link
Collaborator Author

This is now loading in a local test instance without any issues.

Copy link
Member

@samuelscandrett samuelscandrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Jersey environment to test, but if it's working for you I'm happy to merge.

@samuelscandrett samuelscandrett merged commit b78a3f5 into project/7.6.x Oct 10, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants