-
Notifications
You must be signed in to change notification settings - Fork 0
Changes to Package #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
samuelscandrett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still unsure about the structure with having notes as a separate card child of description - it seems like an odd workflow for a user to be required to create a description tile in order to access notes. In an ideal world we would have them both in the same card, but since we need to apply permissions on the notes widget (which doesn't seem to be possible, rather needs to be applied on the entire card) it needs to be moved to a separate card.
I'd double check with the wider dev community whether permissions definitely can't be applied on invidivual widgets within a card, and if this is a requirement is the only solution to move to a separate card.
If this is the only solution, I think it makes the most sense to exist as an entirely separate nodegroup off the root node, and thus in a separate, but unique, card.
samuelscandrett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me
These changes include: