Changes to system settings #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "direction": "ltr", | ||
| "value": "" | ||
| }, | ||
| "en": { |
Member
There was a problem hiding this comment.
I think you're fine to just have the en value and remove the other languages.
(applies for all)
| "feb96005-fa14-11e6-aa8d-6c4008b05c4c": [ | ||
| { | ||
| "accepted": true, | ||
| "altText": { |
Member
There was a problem hiding this comment.
Might be good to have alt text for the images, especially for accessibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #37, a new saved search needed adding. I temporarily added the searches and new image on the staging server and exported system settings to get the code needed.
This is a little hard to test fully, as we need to save the urls with
https://her.jerseyheritage.org, and obviously don't have local access to S3 for the images, but it looks ok in system settings.Once merged, I will delete the saved search from staging and reimport by reloading the package (without the graphs).
Closes: #37