Remove warning on overlapping character classes#175
Open
jneen wants to merge 1 commit intok-takata:masterfrom
Open
Remove warning on overlapping character classes#175jneen wants to merge 1 commit intok-takata:masterfrom
jneen wants to merge 1 commit intok-takata:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re https://bugs.ruby-lang.org/issues/21870
Rationale
In https://bugs.ruby-lang.org/issues/1831, warnings were added for duplicate characters in a character class, specifically to prevent cases like
/[:alpha:]/. However, this was implemented in a much more general fashion, and as of the version of Onigmo in Ruby 4, classes such as\p{Word}and\p{S}now overlap, at ZWJ and ZWNJ specifically.This has resulted in expressions like
/[\p{Word}\p{S}]/emitting an unconditional warning, despite the use of these partially-overlapping classes being unlikely to be a mistake. Duplicate ranges do not seem to incur any performance penalty, as the ranges are simplified at regexp compile time.Proposal
This pull request is the simplest possible solution to the problem - it simply does not check unicode ranges for overlap. This preserves the original intent of the warning:
while allowing character classes to be used freely:
Though I can't necessarily explain why, these also do seem to warn properly with this change, though I had initially expected them not to: