Works in chrome54 #69
Conversation
Because KeyboardEvent.keyIdentifier is deprecated in chrome 54.
* ESC -> Escape * UP -> ArrowUp * DOWN -> ArrowDown * RIGHT -> ArrowRight * LEFT -> ArrowLeft * TAB -> Tab * SHIFT -> Shift * BS -> Backspace * ALT -> Alt * CTRL -> Control * META -> Meta * DEL -> Delete * CR -> Enter * SPACE -> Space
Because KeyboardEvent.key can get original key name, so not need to conversion.
* You can enter special code with ALT + {any key} in mac
* `KeyboardEvent.key` returns special codes when you enter ALT + {any key}
* e.g. you write settings file `A-≈` instead of `A-x`
* The specification breaks old settings. so convert special codes.
* KeyboardEvent.code return `Enter` string when you enter the `Enter` key.
|
@mgi166 Works well in chrome 54(except binding Space in nmap) but unfortunately not working properly in chrome 55. Vichrome works only after refreshing page and searching in history or bookmarks doesn't show hints, tablist is also not working. :-( |
|
@citypops I'm sorry. too late response.
Oh, I don't notify this behavior. But I don't understand the reason that is not working binding with space.
I use chrome 55, but I wasn't able to replicate this bug. I will resource this problem. |
Sorry, I mistake simply. |
2 participants
Fix the issue #67.
This PR works in Chrome 54 for now.
Summary
KeyboardEvent.keyIdentifieris deprecated in Chrome M54. UseKeyboardEvent.keyinstead.KeyboardEvent.keyreturns the charcator you entered. so remove the keycode maps and fix some logics.