Draft: Migrate to UrfaveCLI v3#12184
Closed
acheong08 wants to merge 2 commits intok3s-io:masterfrom
acheong08:master
Closed
Draft: Migrate to UrfaveCLI v3#12184acheong08 wants to merge 2 commits intok3s-io:masterfrom acheong08:master
acheong08 wants to merge 2 commits intok3s-io:masterfrom
acheong08:master
Conversation
Author
|
There are still issues to be resolved, namely Fish completion still doesn't work properly |
Member
|
Due to how containerd is embedded inside K3s, we cannot move to urfaveCLI v3 until that project also moves to it. I handled the migration to V2... and it took 2 years to complete that project. |
Author
Yup I noticed there were still places that relied on v2 - rip. I might just use the partial migration to generate fish completions and that's it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Migrate to urfaveCLI v3, following the migration guide. Notable changes include:
StringSliceFlag->[]stringEnvVars: []string{}->cli.EnvVars()cli.Contexthas been completely removedTypes of Changes
CLI migration
Verification
¯_(ツ)_/¯ - TODO - Works on my machine
Testing
Linked Issues
User-Facing Change
Further Comments
I did this purely to have fish autocomple. Feel free to ignore.