WIP: Allow creation of users through a job#358
Draft
burmanm wants to merge 5 commits intok8ssandra:masterfrom
Draft
WIP: Allow creation of users through a job#358burmanm wants to merge 5 commits intok8ssandra:masterfrom
burmanm wants to merge 5 commits intok8ssandra:masterfrom
Conversation
burmanm
force-pushed
the
user_external_secrets
branch
from
0b2009b to
5ba2985
Compare
burmanm
force-pushed
the
user_external_secrets
branch
from
5ba2985 to
992b0f8
Compare
|
No linked issues found. Please add the corresponding issues in the pull request description. |
…r, modify CRD a bit..
Contributor
Author
|
The new test will not pass without k8ssandra/k8ssandra-client#4 |
adejanovski
added
blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This is WIP of the job approach to creating users, allowing external secrets resources. The CRDs will change, this is just to show it could be done without disabling the original behavior (SuperuserSecretname can now be left empty, if UserInfo is provided and it won't be generated).
There are other secrets in the project also, this PR will not touch those (that will be next PRs) - but instead only move the users creation (currently only superusers) towards a job, using modifications in the k8ssandra-client.
Also, fixes a bug that causes CreateUsers and upsertUsers to be called against Cassandra instance on every reconcile invocation.
Which issue(s) this PR fixes:
Fixes #
Checklist