Add pod liveness check before starting cassandra server.#762
Draft
garrynigel wants to merge 1 commit intok8ssandra:masterfrom
Draft
Add pod liveness check before starting cassandra server.#762garrynigel wants to merge 1 commit intok8ssandra:masterfrom
garrynigel wants to merge 1 commit intok8ssandra:masterfrom
Conversation
garrynigel
changed the title
garrynigel
force-pushed
the
podlivenesscheck
branch
from
2736e9a to
ff5373f
Compare
burmanm
reviewed
Mar 12, 2025
| return false, nil | ||
| } | ||
|
|
||
| func (rc *ReconciliationContext) waitForPodLiveness(pod *corev1.Pod) (bool, error) { |
Contributor
There was a problem hiding this comment.
I know this is still a draft, but this is something one can't do in the reconcile process. The reconcile cannot be blocked (or do anything that's long running), but instead you would need to bail out and try again.
Author
There was a problem hiding this comment.
Got it, will update the liveness check to fail immediately and rely on reconciliation loop to retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #759
Checklist