Bump google.golang.org/grpc from v1.72.1 to v1.79.3#917
Bump google.golang.org/grpc from v1.72.1 to v1.79.3#917shubhi-gupta5 wants to merge 1 commit intok8ssandra:masterfrom
Conversation
- Upgraded google.golang.org/grpc from v1.72.1 to v1.79.3
|
No linked issues found. Please add the corresponding issues in the pull request description. |
|
This is indirect dependency coming from another package. We don't typically update these manually as any update to the real dependency would override this change and also might potentially break compatibility. Is there a real reason to update it? |
@burmanm Thank you for the review! You're absolutely right that this is an indirect dependency. The dependency chain shows that
However, I'm proposing this manual upgrade due to CVE-2026-33186, which is a Critical severity security vulnerability in What would be the preferred approach for handling critical CVEs in indirect dependencies in this project? |
|
That would be those upstream projects. The vuln is in grpc/authz, but I don't see at least controller-runtime using it at all and none of the preconditions are met. Kubernetes seems to ship 1.72.2 even in 1.35.4 (released 5 days ago) and have only updated in their main branch, so I'm not sure if they intend to update at all for any active releases. |
@burmanm Thanks for the clarification! |
|
For now, yes. If we later have to fix it for the CVE scanners, then the correct approach (forgot to mention this) is to set replace directive. That prevents any other updates from downgrading it back to the old version. But those always require maintenance later as they have to be manually also removed so I hope to avoid them. |
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist