Test PR to see if removing enum from lists helps serialise Job type #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client for build reasons.
…client for build reasons.
|
No linked issues found. Please add the corresponding issues in the pull request description. |
…issues in RPC framework.
Miles-Garnsey
force-pushed
the
test/jobstatus-no-enum-in-list
branch
from
06322de to
059d4b5
Compare
Contributor
Author
|
Closing, we ended up hacking around this in #388 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a test to see if the agent will build and run with a Job type returned from
getJobStatus()which does not contain Lists of types containing enums.If it fails the next step will be to remove the
ProgressEventTypeenum entirely and replace it with a string in all locations.