Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
提出用にポート設定を調整するPRだよ〜✨
- nginxのSSLリスニングポートを443→8002に変更🥳
- docker-composeのPostgres/Redisポートをコメントアウトし、nginxのポートマッピングを8002に更新🔒
- フロントエンド環境変数(.env.sample)のAPI/WS URLに:8002を追加📡
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| reverseproxy/nginx.conf | SSLポートを8002に変更 |
| docker-compose.yml | Postgres/Redisのポート定義をコメントアウト/nginxを8002に変更 |
| .env.sample | VITE_API_URL、VITE_WEBSOCKET_URLにポート8002を追記 |
Comments suppressed due to low confidence (3)
docker-compose.yml:23
- 不要になったTODOコメントとコメントアウトされたポート定義は削除して、設定ファイルをクリーンに保つことを検討してください。
# ports:
docker-compose.yml:44
- [nitpick] READMEやドキュメントに、リバースプロキシがホスト側の8002ポートで稼働する旨を追記すると利用者に分かりやすくなります📖
# - "80:80"
.env.sample:10
- [nitpick] .env.sampleにポート番号を指定したURLを更新していますが、用途やカスタマイズ方法をコメントで補足すると導入時の混乱を防げます💡
VITE_API_URL=https://localhost:8002
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
このプルリクエストはmainにmergeしません。
42のリポジトリに提出するためのブランチを見える化するためのものです。
リポジトリに.envファイルがないので(これは正しい状態)、GitHubActionのmakeは必ず失敗します。
やることリスト👉 #259