Fixed "configcheck validates ClusterVectorPipeline (CVP) against all ClusterVectorAggregator instances instead of only matching ones"#208
Merged
aa1ex merged 1 commit intokaasops:mainfrom Nov 24, 2025
Conversation
Contributor
|
The code panics when // Current (crashes when Selector is nil)
if !k8s.MatchLabels(vector.Spec.Selector.MatchLabels, pipelineCR.GetLabels()) {
Fix (same pattern as internal/pipeline/pipeline.go:66-67):
var selectorLabels map[string]string
if vector.Spec.Selector != nil {
selectorLabels = vector.Spec.Selector.MatchLabels
}
if !k8s.MatchLabels(selectorLabels, pipelineCR.GetLabels()) {
continue
}
Apply at lines 147, 189, and 238. |
…ClusterVectorAggregator instances instead of only matching ones"
340bcff to
7523ca2
Compare
aa1ex
added a commit
to aa1ex/vector-operator
that referenced
this pull request
Nov 25, 2025
Regression tests for issue kaasops#201 / PR kaasops#208 - verify CVP is validated only against CVA with matching selector.
aa1ex
added a commit
to aa1ex/vector-operator
that referenced
this pull request
Nov 25, 2025
Regression tests for issue kaasops#201 / PR kaasops#208 - verify CVP is validated only against CVA with matching selector.
aa1ex
added a commit
that referenced
this pull request
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201