Skip to content

fix build with text-2.1.2 #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix build with text-2.1.2 #1383

merged 1 commit into from
Mar 7, 2025

Conversation

larskuhtz
Copy link
Contributor

For text >= 2.1.2 the module Data.Text exports show :: Show a => a -> Text. This causes conflicts in the module Pact.Types.SPV.

This PR fixes this by importing Data.Text qualified.

rsoeldner
rsoeldner approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@rsoeldner rsoeldner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @larskuhtz

@larskuhtz larskuhtz merged commit ebad60e into master Mar 7, 2025
10 of 11 checks passed
@larskuhtz larskuhtz deleted the lars/ghc-9.12 branch March 7, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiegley jwiegley jwiegley approved these changes

@jmcardon jmcardon jmcardon approved these changes

@rsoeldner rsoeldner rsoeldner approved these changes

@emilypi emilypi Awaiting requested review from emilypi emilypi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larskuhtz @jwiegley @jmcardon @rsoeldner