FE: Use theme color definition for warning icon #1282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
We already have a color definition
warningIcon
in our theme which is close to the hard-coded yellow color in the actual template<WarningIcon>
. Use it for consistency and allow theming here.The original theme color
yellow[20]
changes the icon from #F2C94C to #FFDD57 which is close, but drops the contrast ratio on white background from 1.58:1 to 1.33:1.Introduce a darker version
yellow[30]
with #FFD439, so we get at least up to 1.42:1. See screenshots below for comparison.Stumbled across this during #1108
Is there anything you'd like reviewers to focus on?
AFAIK the warning icon is only used in the header for outdated versions (see screenshot at the bottom of the attached image)
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)