-
-
Notifications
You must be signed in to change notification settings - Fork 176
Infra: Run dependabot daily for gradle, npm and docker #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this right now. At the moment, we're limited by the number of open pull requests (30 rn) and bumping interval won't change anything unless we start to merge these PRs more often.
I understand your reasoning, but I think that it'd be easier for me to tag the team in ready-to-go Dependabot security upgrades than to analyze the CVE logs, send the pull request, wait for CI and only then send the pull request for review |
If the bump is CVE-related, these rules (grouping and PR limits) are ignored and PRs are raised as a separate bumps |
Yes, but see this point:
That's why I discovered and created #1354 before the dependabot pull request was created |
Dependencies like Spring are very prone to CVEs and we should not delay receiving and merging fixes when CVEs are found.
Is there anything you'd like reviewers to focus on?
Dependencies such as Spring are highly susceptible to CVEs, so it’s important to promptly receive and merge fixes when vulnerabilities are identified. For example #1354 needed manual intervention due to this same Dependabot timing
Theoretically, Dependabot Security updates(if enabled) should be able to handle security upgrades off-the schedule. However, that heavily depends on a vetted CVE and the corresponding Dependabot alert. For new CVEs where the alert does not exist yet, this may add 2-3 days of latency
Currently, the number of Dependabot pull requests is low because of our grouping configuration, so increasing its run frequency should not create extra noise for maintainers.
I excluded GitHub actions because weekly should be fine for that ecosystem given that the CVE pressure there is low
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
A picture of a cute animal (not mandatory but encouraged)