-
Notifications
You must be signed in to change notification settings - Fork 14
Allow setting the arch of the image to be pulled #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables cross-architecture container image pulling by allowing users to specify the target architecture in the configuration. This is particularly useful when building artifacts for a different architecture than the host system (e.g., building ARM64 images on an AMD64 host).
Key changes:
- Added an
Archfield to the configuration schema - Implemented architecture validation and conversion logic
- Propagated the architecture setting through the image dumping pipeline
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/schema/config.go | Adds Arch field to configuration schema for specifying container image architecture |
| pkg/ops/iso.go | Implements WithArch function to validate and set architecture in agent config |
| pkg/ops/container.go | Updates DumpSource to accept and conditionally apply architecture parameter |
| deployer/steps.go | Passes architecture from config to DumpSource function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 30.63% 30.54% -0.09%
==========================================
Files 25 25
Lines 3023 3045 +22
==========================================
+ Hits 926 930 +4
- Misses 1909 1928 +19
+ Partials 188 187 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d74abc1 to
2d840b7
Compare
because when we are on amd64 host, the auroraboot image is amd64 but we may want to pull and build artifacts for arm64 (e.g. when building rpi raw images). Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
2d840b7 to
bf237f9
Compare
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
because when we are on amd64 host, the auroraboot image is amd64 but we may want to pull and build artifacts for arm64 (e.g. when building rpi raw images). Tested on an amd64 host with this script: