Skip to content

Conversation

@jimmykarily
Copy link
Contributor

@jimmykarily jimmykarily commented Nov 18, 2025

because when we are on amd64 host, the auroraboot image is amd64 but we may want to pull and build artifacts for arm64 (e.g. when building rpi raw images). Tested on an amd64 host with this script:

#!/bin/bash

export IMAGE=quay.io/kairos/alpine:3.21-standard-arm64-rpi4-v3.6.0-rc5-k3s-v1.32.9-k3s1

docker run --rm --privileged \
  -v /var/run/docker.sock:/var/run/docker.sock \
  -v $PWD/build/:/output \
  auroraboot:local \
  --debug \
  --set "disable_http_server=true" \
  --set "disable_netboot=true" \
  --set "state_dir=/output" \
  --set "disk.raw=true" \
  --set "arch=arm64" \
  --set "container_image=${IMAGE}"

@jimmykarily jimmykarily requested a review from a team as a code owner November 18, 2025 08:18
Copilot AI review requested due to automatic review settings November 18, 2025 08:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables cross-architecture container image pulling by allowing users to specify the target architecture in the configuration. This is particularly useful when building artifacts for a different architecture than the host system (e.g., building ARM64 images on an AMD64 host).

Key changes:

  • Added an Arch field to the configuration schema
  • Implemented architecture validation and conversion logic
  • Propagated the architecture setting through the image dumping pipeline

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
pkg/schema/config.go Adds Arch field to configuration schema for specifying container image architecture
pkg/ops/iso.go Implements WithArch function to validate and set architecture in agent config
pkg/ops/container.go Updates DumpSource to accept and conditionally apply architecture parameter
deployer/steps.go Passes architecture from config to DumpSource function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.54%. Comparing base (02cb529) to head (4f3465a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/build-uki.go 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   30.63%   30.54%   -0.09%     
==========================================
  Files          25       25              
  Lines        3023     3045      +22     
==========================================
+ Hits          926      930       +4     
- Misses       1909     1928      +19     
+ Partials      188      187       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jimmykarily jimmykarily self-assigned this Nov 18, 2025
@jimmykarily jimmykarily moved this to In Progress 🏃 in 🧙Issue tracking board Nov 18, 2025
@jimmykarily jimmykarily marked this pull request as draft November 18, 2025 08:44
@jimmykarily jimmykarily marked this pull request as ready for review November 18, 2025 08:49
@jimmykarily jimmykarily moved this from In Progress 🏃 to Under review 🔍 in 🧙Issue tracking board Nov 18, 2025
because when we are on amd64 host, the auroraboot image is amd64 but we
may want to pull and build artifacts for arm64 (e.g. when building rpi
raw images).

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily merged commit 386cb2b into main Nov 18, 2025
13 of 16 checks passed
@jimmykarily jimmykarily deleted the add-arch-option branch November 18, 2025 11:12
@github-project-automation github-project-automation bot moved this from Under review 🔍 to Done ✅ in 🧙Issue tracking board Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants