Fix missing type casting in AGG group qualifier encoding#235
Open
Fix missing type casting in AGG group qualifier encoding#235
Conversation
Predicate values are parsed as String, causing qualifier encoding mismatch. Add PrimitiveType to Group.Field to cast values ?from schema.
zipdoki
commented
Mar 31, 2026
| DataType.DOUBLE -> PrimitiveType.DOUBLE | ||
| DataType.STRING -> PrimitiveType.STRING | ||
| DataType.JSON -> PrimitiveType.OBJECT | ||
| DataType.DECIMAL -> error("DECIMAL is not supported as a group field type. Use a supported type instead.") |
Contributor
Author
There was a problem hiding this comment.
@em3s
DECIMAL group fields are not yet supported — PrimitiveType has no DECIMAL variant. Tracked for a follow-up.
Contributor
|
Left a comment on #227. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cast AGG predicate values using schema field types resolved at entity construction.
Closes #227
What changed
Group.Fieldgains atype: PrimitiveType?field.bucketOrGet()uses it to cast when no bucket is present.LabelEntityfactory methods resolveDataType→PrimitiveTypefrom the schema. Resolution always runs to avoid stale values.DECIMALfields throw an explicit error (not yet supported inPrimitiveType).bucketOrGet()branching and an E2E test covering bucket-only, String+bucket, and Long+bucket group configurations.How to test