Fix if-tag parsing when 'and/or' appear inside string literals#238
Open
petersgecko wants to merge 1 commit intokalimatas:masterfrom
Open
Fix if-tag parsing when 'and/or' appear inside string literals#238petersgecko wants to merge 1 commit intokalimatas:masterfrom
petersgecko wants to merge 1 commit intokalimatas:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor/bin/phpunitbuild/coverage/index.htmlvendor/bin/php-cs-fixer fix(i've not yet managed to run coverage. some tests fail because APC missing etc, but they fail on master on my machine)
Problem
TagIfsplits conditions onand/orusing a regex across the entiremarkup. This incorrectly treats
and/ortokens inside quoted stringliterals as logical operators, e.g.:
{% if course == "art and design" %}This results in the condition being split into multiple parts and
evaluated incorrectly.
Solution
dunno, is this even a thing?