Open
Conversation
This bug was caused by YAML being "helpful" and parsing "NO" as false. YAML will also parse "YES", "No", "no", "on", "off" and many other variations as boolean.
…ars to belong to Cork City.
I would even go so far as to say that in common usage "The Netherlands" is more common than "Netherlands"
UK has left the EU and EEA https://www.gov.uk/eu-eea
Add "The Netherlands" as an unofficial name of NL
CI: Drop unused sudo: false directive
Update UK EU and EEA status
…ounty-data Update Ireland Subdivision Formatting and Connacht and (County) Cork Data
Samoa currency is WST
Add Ñuble region
…-unoffical-names Add Murica to United States unoffical names
…ya-country-code Fix state codes from being returned as false
🇬🇧🇪🇺 Britain leaves the EU and EEA
Fixes failing rspec assertions after cache update
Lewiscowles1986
approved these changes
Feb 11, 2020
Lewiscowles1986
left a comment
Lewiscowles1986
left a comment
There was a problem hiding this comment.
I guess do what you like. I think I'd be cautious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the "Taiwan is not China" on top of the 3.0.1 release of Countries gem.
(The branch has a name with the relevant version number in it.)
Usage idea
Instead of trying to merge this into
masterof this repo, we can point at this branch using Bundler: