fix(FEC-12600): player should support referer without scheme part#4301
Open
lianbenjamin wants to merge 1 commit intomasterfrom
Open
fix(FEC-12600): player should support referer without scheme part#4301lianbenjamin wants to merge 1 commit intomasterfrom
lianbenjamin wants to merge 1 commit intomasterfrom
Conversation
Live Pull Request Urls
|
Contributor
|
@OrenMe |
giladna
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the issue:
sometimes referer header might not include "http" or "https" (i.e.
kaltura.com). in this case, ifkaltura.comis an allowed domain in an ACP, it will not be recognized by the player, since the player is looking forschemepart (http/s) andhostpart. we are using a php function calledparse_urlto break the referer header into url parts. in cases where the referer does not contain a scheme part (http/s), there is also no host, butpathexists instead.solution:
when building the referer, adding another check for
pathattribute.Solves FEC-12600