Deprecated method #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 9f15d11) Conflicts: lib/axr/helpers.rb lib/axr/stars_builder.rb
… original code style
…hen no dimension is set
…going away, and use href instead
… rails3 Conflicts: lib/axr/helpers.rb lib/axr/model.rb lib/axr/stars_builder.rb
Conflicts: CHANGELOG Rakefile ajaxful_rating.gemspec generators/ajaxful_rating/ajaxful_rating_generator.rb generators/ajaxful_rating/templates/style.css init.rb lib/ajaxful_rating.rb lib/axr/helpers.rb lib/axr/model.rb lib/axr/stars_builder.rb
… is passed, Works in 3.07, without dimensons
Use rails.js to submit action, fix in the get parameters to ensure size is passed, Works in 3.07, without dimensions.
Issue solved with "size" params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced ActionController::RecordIdentifier.singular_class_name with ActiveModel::Naming.singular as it has been deprecated in rails 3.