Accept Proc in the `:on` argument by rafaelsales · Pull Request #55 · kamui/retriable

rafaelsales · 2017-10-14T03:38:58Z

houndci-bot · 2017-10-14T03:39:09Z

spec/retriable_spec.rb

+    end
+
+    it '#retriable does not retry with a hash exception where the value is a proc that returns false' do
+      matcher = ->(e, *args) { e.message == 'something went wrong' }


Unused block argument - args. If it's necessary, use _ or _args as an argument name to indicate that it won't be used.

houndci-bot · 2017-10-14T03:39:09Z

spec/retriable_spec.rb

+      expect(tries).must_equal 2
+    end
+
+    it '#retriable does not retry with a hash exception where the value is a proc that returns false' do


Line is too long. [104/80]

houndci-bot · 2017-10-14T03:39:09Z

spec/retriable_spec.rb

    end

+    it '#retriable retries with a hash exception where the value is a proc that returns true' do
+      matcher = ->(e, _try, _elapsed_time, _next_interval) {


Use the lambda method for multiline lambdas.

houndci-bot · 2017-10-14T03:39:09Z

spec/retriable_spec.rb

      expect(exceptions[3].class).must_equal StandardError
    end

+    it '#retriable retries with a hash exception where the value is a proc that returns true' do


Line is too long. [96/80]

houndci-bot · 2017-10-14T03:39:09Z

lib/retriable.rb

    end
  end
+
+  def matched_exception?(on, exception, *additional_args)


Method has too many lines. [14/10]

trivial but maybe rename additional_args to proc_args? so it's explicit in the naming where these args are going.

i don't love the name proc_args so maybe you can think of something better (matcher_proc_args?), but additional_args kind of makes it seem like the args will be used in the matched_exception? method, which they will not.

houndci-bot · 2017-10-14T03:39:09Z

lib/retriable.rb

-        end
-
        interval = intervals[index]
+        raise unless matched_exception?(on, exception, try, elapsed_time.call, interval)


Line is too long. [88/80]

rafaelsales · 2017-10-14T03:43:21Z

@kamui ready!

rafaelsales · 2017-11-05T20:55:12Z

Ping!

apurvis · 2017-11-06T21:16:02Z

README.md

+
+A `Regexp` (or array of `Regexp`s). If any of the `Regexp`s match the exception's message, the block will be retried.
+A `Proc` (or array of `Proc`s) that evaluates the exception being handled and returns `true` if the block should be retried. If any of the procs in the list return `true`, the block will be retried.
+You can also mix and match `Proc`s and `Regexp`s in an `Array`


this is all sort of duplicative of the docs above... it's probably better to just link back there than to duplicate the explanation.

I'm just staying consistent with the style of this documentation. Above there are other expanded versions of what's on those bullet points as well.

apurvis

not sure how much water my opinion carries but in general i think this is a good change.

apurvis · 2017-11-06T21:25:18Z

(you could propose the version bump to 3.2.0 on this PR though maybe @kamui just prefers to handle the version bumping himself)

apurvis · 2018-02-28T08:55:17Z

README.md

+  - A single `Proc` (retries exceptions ONLY if it returns truthy)
  - A single `Regexp` pattern (retries exceptions ONLY if their `message` matches the pattern)
-  - An array of patterns (retries exceptions ONLY if their `message` matches at least one of the patterns)
+  - An array of `Proc` and/or `Regexp` (retries exceptions ONLY if at least one exception matches `Regexp` or the `Proc` evaluates to `true`)


grammar: "retries exceptions ONLY if at least one exception message matches a Regexp or at least one Proc evaluates to true" (or "returns truthy"... not sure which it is but you should be correct and consistent in the documentation).

jcmfernandes · 2019-12-16T10:56:26Z

@kamui @rafaelsales what do we need to do here to get this merged? How can I help?

jcmfernandes · 2020-01-08T17:43:03Z

Ping ^

hound · 2020-02-03T11:41:07Z

lib/retriable.rb

    end
  end
+
+  def matched_exception?(on, exception, *additional_args)


Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

rafaelsales · 2020-02-03T11:59:40Z

@kamui could you take a look at this one?

hound · 2020-02-03T12:36:57Z

spec/retriable_spec.rb

+    it "#retriable does not retry with a hash exception where the value is a proc that returns false" do
+      matcher = ->(e, *_args) { e.message == "something went wrong" }
+      tries = 0
+      expect {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

hound · 2020-02-03T12:36:57Z

spec/retriable_spec.rb

+        e.message == "something went wrong"
+      end
+      tries = 0
+      expect {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

jcmfernandes · 2020-02-03T14:24:51Z

Thank you so much @rafaelsales! Um abraço amigo de Portugal 🙌 .

a-tommyyy · 2022-04-05T07:57:12Z

I hope this feature will be merged.
@kamui

houndci-bot reviewed Oct 14, 2017

View reviewed changes

rafaelsales force-pushed the master branch 2 times, most recently from 772867a to 26ab1bf Compare October 14, 2017 03:42

apurvis reviewed Nov 6, 2017

View reviewed changes

apurvis approved these changes Nov 6, 2017

View reviewed changes

apurvis mentioned this pull request Nov 7, 2017

Set hound line length to 120 #56

Merged

apurvis mentioned this pull request Nov 15, 2017

Swap out pester for Retriable; Retry github errors lumoslabs/aleph#75

Closed

apurvis reviewed Feb 28, 2018

View reviewed changes

Accept Proc in the :on argument

4cc019b

rafaelsales force-pushed the master branch from 26ab1bf to 4cc019b Compare February 3, 2020 11:40

hound bot reviewed Feb 3, 2020

View reviewed changes

rafaelsales added 2 commits February 3, 2020 08:52

Address feedback

4a3180d

Address feedback

b0e1ce2

Convert minitest spec to rspec

9038170

hound bot reviewed Feb 3, 2020

View reviewed changes

kamui force-pushed the master branch from eb3d8e2 to 68c8c26 Compare March 17, 2021 23:05

kamui force-pushed the master branch from 609f786 to af404c5 Compare September 27, 2023 21:00

kamui force-pushed the master branch 3 times, most recently from 6196a1e to c448885 Compare March 20, 2025 03:57

Conversation

rafaelsales commented Oct 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rafaelsales commented Oct 14, 2017

Uh oh!

rafaelsales commented Nov 5, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rafaelsales Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apurvis left a comment

Choose a reason for hiding this comment

Uh oh!

apurvis commented Nov 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcmfernandes commented Dec 16, 2019

Uh oh!

jcmfernandes commented Jan 8, 2020

Uh oh!

hound bot Feb 3, 2020

Choose a reason for hiding this comment

Uh oh!

rafaelsales commented Feb 3, 2020

Uh oh!

hound bot Feb 3, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 3, 2020

Choose a reason for hiding this comment

Uh oh!

jcmfernandes commented Feb 3, 2020

Uh oh!

a-tommyyy commented Apr 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

rafaelsales commented Oct 14, 2017 •

edited

Loading

rafaelsales Feb 3, 2020 •

edited

Loading