Allow to enable/disable Retriable globally#85
Open
fatkodima wants to merge 1 commit intokamui:masterfrom
Open
Conversation
03f3c25 to
0b800f4
Compare
Owner
|
You could just do: # config/initializers/retriable.rb
Retriable.configure do |c|
if Rails.env.development?
c.tries = 1
end
endRight? |
Contributor
Author
|
Yes, for simple cases. I honestly do not remember, which specific example I had in mind. But from README changes you can see, how it also simplifies working with contexts. Sure, you can write something like this for each context: Retriable.configure do |c|
c.contexts[:google_api] = {
tries: Rails.env.test? ? 1 : 5,
base_interval: 3,
on: [
Net::ReadTimeout,
Signet::AuthorizationError,
Errno::ECONNRESET,
OpenSSL::SSL::SSLError
]
}
endBut the proposed solution looks cleaner for me. |
6196a1e to
c448885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily for testing convenience, but can be very useful in development, for example, when you want to quickly disable/reenable retrying.