Open
Conversation
d714dbb to
a775400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements scoped path helper overrides for Bunko-managed collection routes, allowing ergonomic usage (blog_path(@post)) without affecting admin/CMS routes.
Problem
Previous Approach: Override to_param to return slug
User Need:
Solution
Hijack only Bunko-controlled path helpers by dynamically overriding them at route-load time:
Implementation
- bunko_collection :blog registers "blog" with Configuration
- Maintains array of collection path helpers to override
- Generates _path and _url override methods for each registered collection
- Uses define_method to create helpers at runtime
- Installs helper overrides in config.after_initialize
- Includes module in both ActionView and ActionController
Result
Pros vs. Previous Approach
Current (Dynamic Helpers):
Previous (to_param Override):
Files Changed
Open Questions
Recommendation
Consider reverting to to_param approach if:
Keep dynamic helpers if: