Conversation
kangsterizer
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Just a couple of nits - but it would also be helpful if you were able to split the commits in 2:
- the tab/space conversions
- the rest of the p3 conversion
this allows the diff to be more readable and its easier to catch any possible issue
otherwise, ill take another quick look when possible
|
thanks for the review, I totally didn't mean to PR this against upstream yet. I meant to PR it against my own fork as a way to track my progress. Good feedback though, i'll make sure to separate out the tab/space stuff vs. the rest |
This reverts commit 176c216.
ref: convert tabs to spaces, prt 2
|
Made some progress.. Now it's a matter of trying to connect and seeing what breaks. To test i've been running it in th container with:
With the latest changes, it'll start the server, but i haven't successfully managed to connect yet. Still working through the issues. To see the diff without the whitespace changes: 509df1b?diff=unified&w=1 |
| # this is an avaraline extension for nick coloring | ||
| if self.color >= 0: | ||
| data += pack( "!L" , self.color ) | ||
| # if self.color >= 0: |
|
come back! ;) |
Uh oh!
There was an error while loading. Please reload this page.