Fix logging exception which is thrown if command output contains non-ASCII characters#18
Open
Kami wants to merge 1 commit intokantlivelong:develfrom
Open
Fix logging exception which is thrown if command output contains non-ASCII characters#18Kami wants to merge 1 commit intokantlivelong:develfrom
Kami wants to merge 1 commit intokantlivelong:develfrom
Conversation
Kami
commented
Apr 29, 2020
| @@ -1 +1,3 @@ | |||
| OctoPrint | |||
| # six is already required by OctoPrint, but still add it here just in case | |||
| six | |||
Author
There was a problem hiding this comment.
In theory, this shouldn't be needed since OctoPrint already depends on it.
But it also doesn't hurt , especially since we don't pin it to a specific version so there is no chance of a version conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an exception which was thrown when command produced output which contains non-ASCII characters.
Here is an example of the error before the fix:
And after:
I've tested it using Python 2.7 and Python 3.6.