Fix timestamp format in LrcLyricParserTest#87
Merged
andy840119 merged 2 commits intokaraoke-dev:mainfrom Jun 22, 2025
Merged
Conversation
andy840119
reviewed
Jun 22, 2025
Member
There was a problem hiding this comment.
As we discussed before, old format ([mm:ss:xx]) support might be dropped.
Need to:
- should adjust the utils not support the test case.
- (would be better) add new test case to make sure that
[mm:ss:xx]not being supported anymore.
If you are not sure if OK to adjust the utils, should keep both test cases and write the reason why both time format are supported.
andy840119
added
the
Breaking change
Contributor
Author
|
Technically, the support for the old format was already dropped way before. But since it is not even checked in this test case, I don't think we can make this particular test fail for the old format. The tests would need to be placed elsewhere (for example |
Contributor
Author
|
(and since it only modifies some general tests, it is not really a breaking change) |
andy840119
removed
the
Breaking change
Some test cases might be false if not support parsing the lyric without start timing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #85.