Skip to content

Feat/add read more link as properties#1

Open
karlbaumhauer wants to merge 10 commits intomasterfrom
feat/add-read-more-link-as-properties
Open

Feat/add read more link as properties#1
karlbaumhauer wants to merge 10 commits intomasterfrom
feat/add-read-more-link-as-properties

Conversation

@karlbaumhauer
Copy link
Copy Markdown
Owner

Fixes

  • Fixes #

Proposed Changes

  • Change

Read about referenced issues here. Replace words with this Pull Request's context.

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Dec 16, 2022

  • Added an optional target link to the shave function.
  • Updated README with new options and examples for using a target link in Shave.
  • Fixed some linting errors that were introduced by adding the new code (mostly missing semicolons).
  • Added a new option to the shave function called targetLink.
  • The target link is an object that contains text, url and tabindex properties for creating a read more link at the end of truncated content.
  • If no options are passed in then it will default to empty string values so as not break existing functionality or code using this library already (backwards compatibility).
  • I have also added some tests around these changes which can be found in /tests/test-readmorelinkoptions folder within my fork on github: https://github.com/jamesdixon92/shave

Comment thread dist/jquery.shave.js Outdated
Co-authored-by: what-the-diff[bot] <114527992+what-the-diff[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant