Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The treemap visualization is currently canvas-based, which means that screen readers can't interpret any of the 342 occupations or interact with the page in a meaningful way. There are also no landmark regions, the heading hierarchy skips levels, toggle buttons don't expose their active state, and stat updates are silent when switching layers.
This PR fixes all of these issues, while leaving the pre-existing visual design unchanged.
Changes
<header>,<main>) and added a hidden<h2>to aid in navigation and fix the heading hierarchy (was jumping from h1 to h3).aria-pressedon the layer toggle buttons so screen readers announce which layer is active. This updates dynamically when the user switches layers.aria-liveregion that announces a short summary when the layer changes (e.g. "Switched to Median Pay. Avg. pay: $58K")aria-hidden="true"since they're redundant with the table and not keyboard-accessible anyway.Testing