Bug fix for https/GitHub.com/karpathy/jobs/issues/21#22
Open
valera-g wants to merge 6 commits intokarpathy:masterfrom
Open
Bug fix for https/GitHub.com/karpathy/jobs/issues/21#22valera-g wants to merge 6 commits intokarpathy:masterfrom
valera-g wants to merge 6 commits intokarpathy:masterfrom
Conversation
The tooltip is briefly dislplayed to capture its full size and that captured size is used for vertical positioning. Fix is zero-touch coded with GitHub Copilot. Prompt used to generate a fix (original wording preserved): > In this repo is an HTML diagram with data represented as bunch of rectangles. When mouse hover the rectangle, an info card is shown (a popup) and it follows mouse. When the card hits the right edge of the viewport, it jumps to the left of the mouse cursor which is correct behavior. When card hits the bottom of the screen, the part of the card with the lower part with card description is cut off in many cases. Fix it so that the card always constrained in the viewport from the bottom. Do not attempt to fix anything else, but only the positioning when the card hits the bottom edge.
Removed temporary positioning comments for tooltip height measurement.
Author
|
fix for #21 |
Updated GitHub Actions workflow for deploying static content to use new versions of actions and corrected the URL syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tooltip is briefly displayed to capture its full size and that captured size is used for vertical positioning.
Fix is zero-touch coded with GitHub Copilot.
Prompt used to generate a fix (original wording preserved):