#39 Removed backslashes from string #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathavaan
deleted the
bugfix/39-fix-aci-error-with-backslash-in-string
branch
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors SQL filter string construction in the merge_fkb_osm method to improve code readability by eliminating backslash escaping in f-strings.
- Replaced backslash-escaped single quotes with a cleaner quote nesting approach
- Both
fkb_filterandosm_filterconstruction updated consistently
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor change to the SQL filter string construction in the
merge_fkb_osmmethod to improve readability and consistency in how quotes are handled.external_id IN (...)SQL filters in themerge_fkb_osmmethod to use double quotes on the outside and single quotes around each value, improving readability and consistency.