Skip to content

#39 Fixed bug where f-string was unterminated #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jathavaan merged 1 commit into from
Nov 17, 2025
Merged

#39 Fixed bug where f-string was unterminated #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/infra/infrastructure/services/conflation_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,17 +178,11 @@ def merge_fkb_osm(self, release: str, theme: Theme, ids: pd.DataFrame) -> Dict[s
ids_fkb = ids[ids["fkb_id"].notna()]["fkb_id"].to_list()
ids_osm = ids[ids["fkb_id"].isna() & ids["osm_id"].notna()]["osm_id"].to_list()

fkb_filter = (
"FALSE"
if not ids_fkb
else f'external_id IN ({", ".join(f"'{v}'" for v in ids_fkb)})'
)
ids_fkb_str = ", ".join(f"'{v}'" for v in ids_fkb)
ids_osm_str = ", ".join(f"'{v}'" for v in ids_osm)
Comment on lines +181 to +182
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The string joining operations are performed unconditionally, even when ids_fkb or ids_osm are empty lists. This creates unnecessary string operations that won't be used when the filters evaluate to "FALSE". Consider moving the join operations inside the ternary expressions or using lazy evaluation to avoid this overhead.

Example:

fkb_filter = "FALSE" if not ids_fkb else f"external_id IN ({', '.join(f\"'{v}'\" for v in ids_fkb)})"
osm_filter = "FALSE" if not ids_osm else f"external_id IN ({', '.join(f\"'{v}'\" for v in ids_osm)})"

Copilot uses AI. Check for mistakes.

osm_filter = (
"FALSE"
if not ids_osm
else f'external_id IN ({", ".join(f"'{v}'" for v in ids_osm)})'
)
fkb_filter = "FALSE" if not ids_fkb else f"external_id IN ({ids_fkb_str})"
osm_filter = "FALSE" if not ids_osm else f"external_id IN ({ids_osm_str})"

df = self.__db_context.execute(
f'''
Expand Down
Loading