'#42 Set curl as Azure transport option type in DuckDB context config' #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds explicit configuration of the Azure transport option for DuckDB when connecting to Azure Blob Storage. The change sets the azure_transport_option_type to curl, which helps ensure compatibility and stability with Azure storage operations.
- Adds
azure_transport_option_typeconfiguration to the DuckDB context setup - Configures the transport layer to use
curlfor Azure connections
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ); | ||
| """, [Config.BLOB_STORAGE_CONNECTION_STRING]) | ||
|
|
||
| db_context.execute("SET azure_transport_option_type = curl") |
There was a problem hiding this comment.
The value curl should be enclosed in quotes to be treated as a string literal in the SQL SET statement. The correct syntax should be:
db_context.execute("SET azure_transport_option_type = 'curl'")Without quotes, DuckDB may interpret curl as an identifier rather than a string value, which could cause a runtime error.
Suggested change
| db_context.execute("SET azure_transport_option_type = curl") | |
| db_context.execute("SET azure_transport_option_type = 'curl'") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor but important configuration change to the DuckDB context setup. The main update is the explicit setting of the Azure transport option, which can help ensure compatibility and stability when connecting to Azure Blob Storage.
src/infra/persistence/context/duckdb.py: Added a statement to set theazure_transport_option_typetocurlin the DuckDB context creation function.