Skip to content

Conversation

@jathavaan
Copy link
Collaborator

This pull request introduces infrastructure improvements and environment configuration updates to support deployment and service integration. The most significant changes involve adding Kubernetes job configuration, updating Docker Compose to use environment variables, and correcting import paths in service files.

Deployment and Infrastructure:

  • Added a new Kubernetes job configuration file k8s/job.yaml to define a batch job for the building conflation pipeline, including container setup, secrets, and restart policy.
  • Updated docker-compose.yml to load environment variables from a .env file for the osm-pipeline service, improving local development and configuration management.

Service Import Corrections:

  • Fixed import paths in src/infra/infrastructure/services/fkb_service.py to use fully qualified src. prefixes and included missing IBlobStorageService in the imports.
  • Corrected import statements in src/infra/infrastructure/services/open_street_map_service.py to use src. prefixes and included missing IBytesService in the imports.

Workflow Configuration:

  • Added a .github/workflows/events/pr.json file to specify pull request event conditions for GitHub Actions workflows.

@jathavaan jathavaan self-assigned this Jan 28, 2026
Copilot AI review requested due to automatic review settings January 28, 2026 09:12
@jathavaan jathavaan linked an issue Jan 28, 2026 that may be closed by this pull request
4 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR wires up infrastructure for running the building conflation pipeline in Kubernetes, aligns service imports with the src. package layout, and improves local configuration management.

Changes:

  • Added a k8s/job.yaml manifest to run the osm-pipeline container as a Kubernetes Job with secrets and image pull credentials.
  • Updated fkb_service and open_street_map_service to use fully qualified src.application.contracts / src.domain.enums imports, adding missing interface imports.
  • Enhanced docker-compose.yml to load environment variables from a .env file, extended .gitignore to ignore .secrets, and introduced .github/workflows/events/pr.json for PR event configuration.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/infra/infrastructure/services/open_street_map_service.py Fixes service and enum import paths to use the src. namespace and ensure all required interfaces are imported.
src/infra/infrastructure/services/fkb_service.py Switches imports to src.-scoped modules and includes IBlobStorageService in the contracts used by FKBService.
k8s/job.yaml Introduces a Kubernetes Job manifest to run the osm-pipeline image with production secrets and registry credentials.
docker-compose.yml Configures the osm-pipeline service to load configuration from a .env file for local development.
.gitignore Adds .secrets to ignored files and maintains ignoring of profiling JSON outputs.
.github/workflows/events/pr.json Adds a JSON file describing pull request event conditions, presumably for use by GitHub Actions-related tooling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Jan 28, 2026

@jathavaan I've opened a new pull request, #62, to work on those changes. Once the pull request is ready, I'll request review from you.

@jathavaan jathavaan merged commit e5803d9 into main Jan 28, 2026
@jathavaan jathavaan deleted the feature/57-configure-a-local-kubernetes-cluster-using-kind branch January 28, 2026 09:20
jathavaan added a commit that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure a local Kubernetes cluster using Kind

2 participants