-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/57 configure a local kubernetes cluster using kind #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/57 configure a local kubernetes cluster using kind #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR wires up infrastructure for running the building conflation pipeline in Kubernetes, aligns service imports with the src. package layout, and improves local configuration management.
Changes:
- Added a
k8s/job.yamlmanifest to run theosm-pipelinecontainer as a Kubernetes Job with secrets and image pull credentials. - Updated
fkb_serviceandopen_street_map_serviceto use fully qualifiedsrc.application.contracts/src.domain.enumsimports, adding missing interface imports. - Enhanced
docker-compose.ymlto load environment variables from a.envfile, extended.gitignoreto ignore.secrets, and introduced.github/workflows/events/pr.jsonfor PR event configuration.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/infra/infrastructure/services/open_street_map_service.py |
Fixes service and enum import paths to use the src. namespace and ensure all required interfaces are imported. |
src/infra/infrastructure/services/fkb_service.py |
Switches imports to src.-scoped modules and includes IBlobStorageService in the contracts used by FKBService. |
k8s/job.yaml |
Introduces a Kubernetes Job manifest to run the osm-pipeline image with production secrets and registry credentials. |
docker-compose.yml |
Configures the osm-pipeline service to load configuration from a .env file for local development. |
.gitignore |
Adds .secrets to ignored files and maintains ignoring of profiling JSON outputs. |
.github/workflows/events/pr.json |
Adds a JSON file describing pull request event conditions, presumably for use by GitHub Actions-related tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@jathavaan I've opened a new pull request, #62, to work on those changes. Once the pull request is ready, I'll request review from you. |
This pull request introduces infrastructure improvements and environment configuration updates to support deployment and service integration. The most significant changes involve adding Kubernetes job configuration, updating Docker Compose to use environment variables, and correcting import paths in service files.
Deployment and Infrastructure:
k8s/job.yamlto define a batch job for the building conflation pipeline, including container setup, secrets, and restart policy.docker-compose.ymlto load environment variables from a.envfile for theosm-pipelineservice, improving local development and configuration management.Service Import Corrections:
src/infra/infrastructure/services/fkb_service.pyto use fully qualifiedsrc.prefixes and included missingIBlobStorageServicein the imports.src/infra/infrastructure/services/open_street_map_service.pyto usesrc.prefixes and included missingIBytesServicein the imports.Workflow Configuration:
.github/workflows/events/pr.jsonfile to specify pull request event conditions for GitHub Actions workflows.