Refactor/61 remove unused code #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor/61-remove-unused-code
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes two presentation notebooks and cleans up unused imports in FKB service interfaces. The code changes themselves are straightforward, but the notebook deletions are broader than what the PR description currently states.
Changes:
- Delete
04-1-conflation-same-source-search.ipynbfrom the presentation notebooks. - Delete
02-2-fkb-conversion.ipynbfrom the presentation notebooks. - Remove unused
pystac.CatalogandBytesIOimports fromfkb_service_interface.pyandfkb_file_service_interface.pyrespectively.
Reviewed changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/presentation/notebooks/04-1-conflation-same-source-search.ipynb |
Entire notebook removed from the repository. |
src/presentation/notebooks/02-2-fkb-conversion.ipynb |
Entire notebook removed from the repository. |
src/application/contracts/fkb_service_interface.py |
Removed unused pystac.Catalog import; interface continues to use geopandas and EPSGCode only. |
src/application/contracts/fkb_file_service_interface.py |
Removed unused io.BytesIO import; interface now only exposes byte-based ZIP APIs and geopandas return types. |
Comments suppressed due to low confidence (2)
src/presentation/notebooks/04-1-conflation-same-source-search.ipynb:1
- The PR description mentions only minor import cleanups in service interface files with no functional or behavioral changes, but this change fully removes this notebook file. Please confirm that deleting this notebook is intentional and consider updating the PR description to reflect this broader change.
src/presentation/notebooks/02-2-fkb-conversion.ipynb:1 - The PR description states that only minor import cleanups in service interface files are being made with no functional or behavioral changes, but this change completely removes this notebook. Please verify that this deletion is intended and update the PR description if necessary to reflect the removal of presentation notebooks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes minor improvements to import statements in two service interface files. The changes primarily involve cleaning up unused imports to keep the codebase tidy. No functional or behavioral changes were introduced.