pmtiles fix: suggested fix for windows line endings in shell script #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the script was copied to the Linux Docker container, the \r characters from Windows line endings were interpreted as literal characters, causing syntax errors like: $'\r': command not found set: -: invalid option syntax error: unexpected end of file The solution was to: Convert the shell script from Windows line endings (\r\n) to Unix line endings (\n) Copy the converted script to the Docker container Make sure the script is executable with chmod +x
espen080
requested changes
Sep 22, 2025
Collaborator
espen080
left a comment
espen080
left a comment
There was a problem hiding this comment.
Supert om du tar bort output, da blir det litt lettere å se hva som er endret :)
Some et alternativ til å endre filen i python koden er det og mulig å kjøre en util som heter unix2dos i docker filen slik at dilen alltid vil ha unix line endings i imaget, opp til deg om du vil gjøre noe med dette eller la det stå som det er :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the script was copied to the Linux Docker container, the \r characters from Windows line endings were interpreted as literal characters, causing syntax errors like:
$'\r': command not found
set: -: invalid option
syntax error: unexpected end of file
The solution was to:
Convert the shell script from Windows line endings (\r\n) to Unix line endings (\n) Copy the converted script to the Docker container
Make sure the script is executable with chmod +x
Feat: Added global .gitignore for venv, .venv and pycache