Conversation
TODO: test with / without parley, if it remains optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #607.
Adds support for rendering Parley
GlyphRunobjects. Since we already use Swash for rastering glyphs, this isn't too hard.Caveat: this code probably loads the fontique font database and each used font twice (once by Parley and once by kas-text). This should be solvable but probably requires changes to Parley (linebender/parley#373).
Adds support for sizing Parley text objects and a Parley text widget. This code is hacky and badly rebased (originally written in May, rebased now but without fixing much of the code).
This was written as a proof-of-concept, motivated in part by the differences between kas-text (greater focus on performance) and Parley (more capabilities, modelled to some extent on CSS).
I'm not really convinced we want this.