ListView: add fns with_load_ahead, with_min_alloc_len#659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support (predictive) load-ahead and load cache for
ListViewview widgets, and use in the file explorer.Note that load-ahead and caching could instead be implemented in the async clerk. This would be "better" (in that only the minimum amount of data is cached, not whole widgets) but would require significant revisions to the file explorer and also would require using
Spriteover custom code rendering images and SVG to (GPU) buffers instead of using theImageandSvgwidgets.Since this approach only really requires a couple of lines in the (
file-explorer) app this approach will be preferable for many users.