kas-text update, minor simplifications to the text APIs#668
Merged
Conversation
dhardy
force-pushed
the
push-uxowowsroywp
branch
from
07a30d6 to
3eaa4a0
Compare
dhardy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove fn
ThemeDraw::textsince effectively it's only a very minor optimisation overtext_effects.Remove generics from fn
DrawCx::text_with_effects. This makes calling the method slightly less convenient but this isn't a big deal (in most cases one of the higher-level text fns is used instead). Moreover, I wish to emphasise that this is a low-level method.Updates kas-text for kas-gui/kas-text#126.