VNC-104 properly support frame rates from 10 to 120#170
Open
mmcclaskey wants to merge 1 commit intomasterfrom
Open
VNC-104 properly support frame rates from 10 to 120#170mmcclaskey wants to merge 1 commit intomasterfrom
mmcclaskey wants to merge 1 commit intomasterfrom
Conversation
quickiwiki
reviewed
Nov 7, 2025
| const frameRate = Math.round(Math.max(10, Math.min(120, this.frameRate))); | ||
| if (frameRate !== this.frameRate) { | ||
| Log.Warn("Frame rate value " + this.frameRate + " adjusted to " + frameRate); | ||
| } |
Collaborator
There was a problem hiding this comment.
Should this.frameRate be assigned frameRate?
quickiwiki
reviewed
Nov 7, 2025
Collaborator
quickiwiki
left a comment
quickiwiki
left a comment
There was a problem hiding this comment.
Left a small question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires accompanying changes on the server side to support up to 120 fps.