Open
Conversation
MtrXPL
force-pushed
the
feature/KASM-5489-mutimonitor-fixes
branch
2 times, most recently
from
2140ee8 to
a6362e5
Compare
mmcclaskey
requested changes
Feb 1, 2024
Collaborator
mmcclaskey
left a comment
mmcclaskey
left a comment
There was a problem hiding this comment.
@MtrXPL , for whatever reason, this branch is fairly broken. When you add a display, things get unusable. I recently refactored things in rfb.js, so perhaps it worked properly when you first created this. I suspect that rfb.applyScreenPlan is not getting called after the secondary screen checks in, but I have not dive deep into the issue.
MtrXPL
force-pushed
the
feature/KASM-5489-mutimonitor-fixes
branch
from
a6362e5 to
2be3bf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.