Added Docker image build script and workflow#5
Conversation
|
We recently tried having Github container registry, should we support that? As a reference, see dnsseeder here. |
Thats merely a matter of setting the correct values for the 2 secrets and 2 variables. I don't see any reason to though as it merely makes the image tag longer.
I can take a quick look at the layered approach, in my experience it introduces a lot of complexity and pitfalls. |
Agreed, more container registry supported the better. |
…ly compiled by default. Removed CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse as its default.
|
Should we try one release creation on your fork before merging this one? Lastly, what do you think of adding at least a quick line on the README to give running instruction using this method? |
Release build: https://github.com/supertypo/cpuminer/actions/runs/22279446026 By instructions in README, you mean explaining the secrets and vars having to be set? |
Awesome, thank you very much @supertypo for your effort here.
I was simply thinking of a "copy-pastable" |
Ah, docker instructions is probably wise to have. I'll add a plain run and compose file example 👍 |
|
Updated README @IzioDev |
Produces multi-arch docker images on push.
versions:
The following vars and secrets must be set in the repository settings:
vars:
DOCKER_REPO=kaspanet/cpuminer
DOCKER_USER=user with push privileges on docker hub
secrets:
DOCKER_ACCESS_TOKEN=users access token with push privileges on docker hub
GH_TOKEN=github access token with epo, write:packages permission